statistics: fix a bug which causes panic when using the clustered index and the new collation #21379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
requested review from
winoros and
qw4990
and removed request for
XuHuaiyu
Closed
ti-srebot
approved these changes
Dec 1, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-check_dev_2 |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 1, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #20876
Problem Summary:
The statistics data is "sort key" and shouldn't take as collate strings. If so, reencode the non-UTF-8 sort key may cause panic.
What is changed and how it works?
Don't set collate for the sort key.
Related changes
Check List
Tests
Side effects
Release note